Re: Formatting controllers

[Tim Ruppert]

"consistent enough" is tough when it slips thru the crack and it's not always consistent. I have to admit to liking it being explicit - but it's really trivial enough to go either way. Some people put the bracket on the same line - some the next. You really just have to pick a guideline and stick to it as far as I'm concerned.

Cheers,
Ruppert

On Nov 19, 2009, at 11:44 PM, David E Jones wrote:

On Nov 19, 2009, at 6:46 AM, Ashish Vijaywargiya wrote:

Hello Jacques,

The following changes are good:

auth="true"/><response name="success" type="view"
value="FindSubscriptionResource"/></request-map>

auth="true"/><response name="success" type="view"
value="EditSubscriptionResource"/></request-map>
+    <request-map uri="FindSubscriptionResource">
+        <security https="true" auth="true"/>
+        <response name="success" type="view"
value="FindSubscriptionResource"/>
+    </request-map>
+    <request-map uri="EditSubscriptionResource">
+        <security https="true" auth="true"/>
+        <response name="success" type="view"
value="EditSubscriptionResource"/>
+    </request-map>

- <request-map uri="FindSubscriptionResource"><security https="true" - <request-map uri="EditSubscriptionResource"><security https="true"

-David

I disagree. That change turns one line into four, and the pattern for those entries is generally consistent enough that reading beyond the first 50 characters or so it totally redundant information.

line:


invoke="updateProductQuickAdminShipping"/>

+            invoke="updateProductQuickAdminShipping"/>

And for view map entries - +1.


--
Ashish


On Thu, Nov 19, 2009 at 6:44 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

*But* I don't like the changes for moving "invoke" attribute to the new - <event type="java" path="org.ofbiz.product.product.ProductEvents" + <event type="java" path="org.ofbiz.product.product.ProductEvents"

Hi devs,

I often found myself in difficulties when reading controllers files.

I would like to format them all as it's done on the attached example

http://n4.nabble.com/file/n623986/controller.patch controller.patch , but

the view-maps which I would prefer to keep on one line.

Opinions ?

Thanks

Jacques
--
View this message in context:
http://n4.nabble.com/Formatting-controllers-tp623986p623986.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

smime.p7s
Description: S/MIME cryptographic signature