On Mar 19, 2010, at 6:11 PM, Ean Schuessler wrote: > Jacopo Cappellato wrote: >> OrderShipment is used now, because I refactored the code in that commit; it >> was not used before that (apart from the "shipment plan" screen I mentioned, >> but as I said I doubt companies could use it in production). >> > I understand. I thought you were asking why his importer would use that > entity. > > You were making the point that the normal deprecation procedure was > unnecessary because there wasn't any code in trunk that populates this entity.
This is not exactly what I wrote: "no code was using the OrderShipment entity, no code apart from some old code (that I wrote) related to manufacturing shipment plans [...]" > I mostly agree with you but this entity has been in place for years and is > documented in the Data Model Resource Book. Yes, I contributed this work a lot of time ago indeed. > If the entity was a recent OFBiz invention (ie. post 09.04) and had never > been used by code in trunk then I would agree with you 100%. > > The deprecation procedure as currently specified leaves much to be desired > but its all we currently have and it is the policy. Agreed. Btw, (and this question is not specifically addressed at you, Ean) when did it happen that our best practices became "policies"? Moreover, I don't remember of a vote to establish, not only this, but any of the "policies" and "rules" so frequently mentioned in this list, Kind regards, Jacopo > > -- > Ean Schuessler, CTO > e...@brainfood.com > 214-720-0700 x 315 > Brainfood, Inc. > http://www.brainfood.com >
