The author is willing to change the license, allow some time here..... On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: > OK, I will have to revert this commit (it's our duty), unless someone take > care of the GPL issues... > > Thanks > > Jacques > > From: "Jacques Le Roux" <jacques.le.r...@les7arts.com> > > Bump...! > > > > Jacques > > > > From: "Jacques Le Roux" <jacques.le.r...@les7arts.com> > >> Hans, > >> > >> Could you please check that removing > >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > >> lets the > >> feature to continue to work? > >> > >> Jacopo: > >> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a > >> simple note in NOTICE is enough > >> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in > >> NOTICE is enough: http://jquery.malsup.com/license.html > >> jquery.function.js should be licensed by us (it's obviously a covert) > >> > >> But jquery.Rotate.js is a real issue: LGPL > >> http://code.google.com/p/jquery-rotate/ and should not be commited in our > >> repo > >> > >> Jacques > >> > >> From: "Jacques Le Roux" <jacques.le.r...@les7arts.com> > >>>I did not notice, this is messy. We already have jQuery 1.4.2 (we have > >>>also 1.4.3 and 1.4.4 but they are buggy and blocking for > >>>us) in framework/images so we don't need an older jQuery > >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > >>> is v1.3.2. > >>> > >>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues > >>> with it for imagemanagement (I doubt) > >>> > >>> I'd strongly recommend for any new jQuery stuff to follow the path we > >>> used so far (have all centralized in framework/images) > >>> > >>> > >>> Also I can't connect to http://deepliquid.com/content/Jcrop.html > >>> (actually I get a blank screen) > >>> > >>> And... I'm tired... :/ > >>> > >>> Jacques > >>> > >>> From: "Jacopo Cappellato" <jacopo.cappell...@hotwaxmedia.com> > >>>> Should the following files without a license header be mentioned in the > >>>> LICENSE file? > >>>> > >>>> Jacopo > >>>> > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > >>>> > >>>> > >>> > >>> > >> > >> > > > > > >
-- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
