[ 
https://issues.apache.org/jira/browse/OFBIZ-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738773#comment-13738773
 ] 

Taher Alkhateeb commented on OFBIZ-5267:
----------------------------------------

Hi Jacques,

I think your second option above is a good one. There are, however, few points 
of concern:

# I think that some tests cannot happen simultaneously simply because one 
webapp is overriding another. For example, say that you have two reports, one 
implemented in FOP and the other one in BIRT both mapped to same request, and 
both reports have tests associated with them (including the screen that 
generates them). Given that one weapp is overriding another, it is difficult to 
test both at the same time, especially if you have functional tests.
# specialpurpose components might become a bit difficult to develop because you 
don't know how much of it is in the component's directory vs the directory of 
the other components.
# Although it does not break the system, you still have stuff in applications 
pointing outwards to specialpurpose

On the other hand, consider a scenario perhaps like this one:

# By default all specialpurpose components that override other components are 
disabled
# Create a simple patch to enable all such components
# Create two build jobs in jenkins (or whatever builder), the first one tests 
everything, the second one tests everything after applying the above patch, and 
the two builds always occur consecutively.

This way, you continue to enjoy testing everything on all components without 
breaking the isolation of lower components from upper ones, and everytime you 
have a new specialpurpose component, you update your patch to handle it.

It's not pretty, but then again this whole override concept makes things rather 
tricky and difficult. Anyway, I'm just pouring my thoughts out here hoping some 
might stick. Thank you for the excellent explanations above, I will focus next 
on improving the existing BIRT reports in another JIRA
                
> Net before overhead report generates an error
> ---------------------------------------------
>
>                 Key: OFBIZ-5267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>
> When trying to generate a 'Net Before Overhead Report' in ORDERMGR:Reports 
> following error is shown:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [NetBeforeOverheadReport.pdf]; this request does not exist or cannot be 
> called directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to