Yes, I was maybe abusing there indeed. But note that I did not add a tool in the repo, only added something to ignore it. This should be transparent
to everybody.
Like for the desktop.ini entry in the .*ignore files I don't see a reason to not add a readymade patch for console.log. Again, it would be transparent
to everybody, but convenient for those who want it.
I understand you want to keep things as clean as possible, but are we not going
too far in our slimdown crusade?
Now about the error.log, I will re-add it. I think it makes sense and is not
really complicating log4j2.xml.
Jacques
Le 09/09/2014 08:30, Adrian Crum a écrit :
Jacopo,
Thank you for mentioning the .svnignore and .gitignore commit - that bothers me too. We should be ignoring things in the repo, not our personal
modifications.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 9/9/2014 7:20 AM, Jacopo Cappellato wrote:
On Sep 9, 2014, at 7:08 AM, Jacques Le Roux <jacques.le.r...@les7arts.com>
wrote:
[...] On the other hand I can agree that having a lot of logs written can slow down the system. And I guess that's the reason why Jacopo and you
are against multiplying them. [...]
This is not what I wrote in my previous email; quoting here for your
convenience:
"The only reason is to keep the default configuration as simple, generic and minimal as possible. As you said, it is very easy for each developer
to customize to fit it to his/her own preferences."
I believe, contrary to console.log, simply re-adding error should not have an important impact in most circumstances, hopefully you have not that
much error in your instance.
The idea is I don't want to have to manually re-add it each time I want it. For console.log these cases are less frequent, so doing it by hand
then will not be a problem. I will even maybe add a patch for console.log in the repo, ready to use...
Please, don't do this: let's all try to keep the public repo as clean as possible without adding stuff to facilitate our personal workflow; for
example, the commit you did yesterday to .svnignore and .gitignore is really ugly (your commit message was "I found convenient to have an icon in
Windows File explorer for my local OFBiz checkouts, must ignore it"): I didn't comment because I don't want to be too peaky but in my opinion it is
a symptom of a wrong concept of the repository. I have plenty of tools and scripts in my local environment that are useful to me but not a good fit
for the project and I don't put them in the repository just because it will be easier for me to find them there every time I do a checkout.
Jacopo
