Okay I missed the historical context. Like Jacopo I also do not have a strong opinion, if it is easier and faster to keep them, then keep them. The important thing is to take a direction and stay with it.
On Sep 13, 2016 9:40 AM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> wrote: Hi, Wait, I did not ask to remove them. I simply asked "Should we continue to put them, and if yes for which reasons? " I don't want to remove existing ones (easy done in one shoot with a S/R regexp) because it would remove the precious svn annotations (when you want to look for reasons in the past) I just want to stop put them when we refactor/fix/etc. I know it will introduce inconsistency (and I assume you know how much I dislike inconsistency) but if the price to pay is to lose again the *precious svn annotation*, by changing almost of lines of all Groovy files, then I'd say it's not worth it Thank you Rishi for the link to https://cwiki.apache.org/confl uence/display/OFBIZ/Tips+and+Tricks+while+working+with+Groovy I did not remember of it. I changed the title to make the URL easier to read Jacques Le 13/09/2016 à 08:23, Rishi Solanki a écrit : > Jacopo, > > I could recall after your reply, the semicolon kept in the groovy files for > consistency only no other reason. Also, if we decide to remove it, then > only thing we should consider if somewhere semicolon used as separator. > > Thanks! > > -- > Rishi > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Tue, Sep 13, 2016 at 11:46 AM, Jacopo Cappellato < > jacopo.cappell...@hotwaxsystems.com> wrote: > > I don't have a strong opinion. But it would be nice to agreed upon one >> style and then implement consistently. >> >> Jacopo >> >> On Mon, Sep 12, 2016 at 6:56 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Hi >>> >>> While committing r1760406 I wondered if I should really put semicolons >>> >> at >> >>> end of Groovy files lines. >>> We know it's useless in Groovy. Should we continue to put them, and if >>> >> yes >> >>> for which reasons? >>> >>> Thanks >>> >>> Jacques >>> >>> >>>
