[
https://issues.apache.org/jira/browse/ONAMI-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591671#comment-13591671
]
Simone Tripodi commented on ONAMI-98:
-------------------------------------
thanks for reviewing Mikhail, see my replies inline:
- Why Guice have "provided" scope in dep. management? I think it should be
"compile".
-1, it is expected that users using Onami extensions already plugged Guice in
their systems
- We can set scope for JUnit, TestNg dependencies to be "test" to avoid setting
it in each module.
-1 as well, Onami-Test needs a different scope
- We may want to remove explicit "compile" scope and "jar" type from all
dependencies from all modules because they are defaults. Less noise in poms.
+1
- Manage all dependencies' versions from parent dependency management to ensure
consistent versions and easy maintenance.
isn't it what we already do?
> Improve dependency management
> -----------------------------
>
> Key: ONAMI-98
> URL: https://issues.apache.org/jira/browse/ONAMI-98
> Project: Apache Onami
> Issue Type: Improvement
> Components: parent
> Affects Versions: parent-3
> Reporter: Mikhail Mazursky
> Priority: Minor
>
> - Why Guice have "provided" scope in dep. management? I think it should be
> "compile".
> - We can set scope for JUnit, TestNg dependencies to be "test" to avoid
> setting it in each module.
> - We may want to remove explicit "compile" scope and "jar" type from all
> dependencies from all modules because they are defaults. Less noise in poms.
> - Manage all dependencies' versions from parent dependency management to
> ensure consistent versions and easy maintenance.
> WDYT?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
