I'm with simone. Guice should be marked as "provided". Onami is a pluggable toolset, which you add to maven if you need a nice feature out of it. But it is not a first class citizen, which you specify without knowing what Guice is.
I would also force the people to declare by theirself, so they decided active that they want to use Guice. 2013/3/3 Simone Tripodi (JIRA) <[email protected]> > > [ > https://issues.apache.org/jira/browse/ONAMI-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591698#comment-13591698] > > Simone Tripodi commented on ONAMI-98: > ------------------------------------- > > The fact that Onami users already depend on Guice proves that Onami > extensions are useless without Guice. There's no workaround. > "a project can depent on Onami-x but don't have Guice dependency directly > [...]" Uh?!? Again: how would you use an Onami-XXX without Guice? You still > have to create the Injector by yourself with your application Module(s). > > " 'provided' scope is used to decouple API from implementation in concrete > container." is something _you_ are saying, taking a sample as a strict > rule. And "a" container, doesn't mean the JEE container. In our case, Giuce > is the DI container - how would you object it? :) > > Generally speaking: I don't blindly apply a rule simply because someone > already did it in a way. If they evaluated that, for their usecases, > something is fine, it doesn't mean that could work for me as well. > > Have a look at the Onami-Test codebase to see why scopes changed from > `provided` to `compile` for Junit and other Mocking frameworks. > > > Improve dependency management > > ----------------------------- > > > > Key: ONAMI-98 > > URL: https://issues.apache.org/jira/browse/ONAMI-98 > > Project: Apache Onami > > Issue Type: Improvement > > Components: parent > > Affects Versions: parent-3 > > Reporter: Mikhail Mazursky > > Priority: Minor > > > > - Why Guice have "provided" scope in dep. management? I think it should > be "compile". > > - We can set scope for JUnit, TestNg dependencies to be "test" to avoid > setting it in each module. > > - We may want to remove explicit "compile" scope and "jar" type from all > dependencies from all modules because they are defaults. Less noise in poms. > > - Manage all dependencies' versions from parent dependency management to > ensure consistent versions and easy maintenance. > > WDYT? > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira > -- Viele Grüße/Best Regards Daniel Manzke
