[
https://issues.apache.org/jira/browse/ONAMI-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591710#comment-13591710
]
Mikhail Mazursky commented on ONAMI-98:
---------------------------------------
Ok, Onami without Guice was nonsense =) Actually i was trying to say that a
project can depend on Onami but do not have maven dependency on Guice but Guice
would be added to it transitively IF it was "compile" scoped in Onami's pom.
And that makes sense - if you add a dep. then it should bring you everything it
needs transitively.
Guice is a DI container, yes. But it's not a container that runs application.
It's inside the application.
It's really the first time i came across such scope usage and i can't find a
source where scopes are described in such details to judge if its correct or
not. All i know is that all "provided" usages i ever saw were for
container-provided deps. =)
"Have a look at the Onami-Test codebase to see why scopes changed from
`provided` to `compile` for Junit and other Mocking frameworks. "
Onami-Test has them as "provided" right now, not as "compile". And what i was
saying above is that they should be "compile".
p.s. I don't understand why "provided" is not transitive - there is a bug for
it [1] and it's been there for a long time but it's neither closed as "won't
fix"/"working as intended" nor fixed.
[1]: http://jira.codehaus.org/browse/MNG-2205
> Improve dependency management
> -----------------------------
>
> Key: ONAMI-98
> URL: https://issues.apache.org/jira/browse/ONAMI-98
> Project: Apache Onami
> Issue Type: Improvement
> Components: parent
> Affects Versions: parent-3
> Reporter: Mikhail Mazursky
> Priority: Minor
>
> - Why Guice have "provided" scope in dep. management? I think it should be
> "compile".
> - We can set scope for JUnit, TestNg dependencies to be "test" to avoid
> setting it in each module.
> - We may want to remove explicit "compile" scope and "jar" type from all
> dependencies from all modules because they are defaults. Less noise in poms.
> - Manage all dependencies' versions from parent dependency management to
> ensure consistent versions and easy maintenance.
> WDYT?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
