[ 
https://issues.apache.org/jira/browse/ONAMI-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591692#comment-13591692
 ] 

Mikhail Mazursky commented on ONAMI-98:
---------------------------------------

The fact that Onami users already depend on Guice doesn't prove anything - the 
Guice dependency isn't provided by container/JDK. "provided" scope is used to 
decouple API from implementation in concrete container. Also, this can be a 
problem - a project can depent on Onami-x but don't have Guice dependency 
directly. If that project is added as a dependency then Guice will not be added 
transitively. NoClassDefFoundError at runtime :)
Also, haven't my examples of other Guice extensions convinced you? You think 
those projects are misusing scopes? :)

Sorry, can't get your point on Onami-Test - probably my english is not enough 
to understand =) What do you mean by "scopes changed there"?
                
> Improve dependency management
> -----------------------------
>
>                 Key: ONAMI-98
>                 URL: https://issues.apache.org/jira/browse/ONAMI-98
>             Project: Apache Onami
>          Issue Type: Improvement
>          Components: parent
>    Affects Versions: parent-3
>            Reporter: Mikhail Mazursky
>            Priority: Minor
>
> - Why Guice have "provided" scope in dep. management? I think it should be 
> "compile".
> - We can set scope for JUnit, TestNg dependencies to be "test" to avoid 
> setting it in each module.
> - We may want to remove explicit "compile" scope and "jar" type from all 
> dependencies from all modules because they are defaults. Less noise in poms.
> - Manage all dependencies' versions from parent dependency management to 
> ensure consistent versions and easy maintenance.
> WDYT?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to