krickert commented on PR #1003: URL: https://github.com/apache/opennlp/pull/1003#issuecomment-4176758646
@atarora @jzonthemtn @rzo1 @mawiesne Just curious - what are the next steps? I'm not in a rush - just not familiar with the cadence for reviews with this repo. I'm most curious if I ran the tests enough to convince others of the advantages or if more testing is required so clarify the speedup factor and correctness of the solution. Suggest anything to help ease the review. I'm also open for a discord / any platform chat if that makes it easier too. Moving to a thread-safe approach should make it a lot easier to code against - I frequently forgot that it's not thread safe over the years and had to redo the same strategies and seeing the speed up has made me excited to contribute more in the future. I'll also update the documentation once it's approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
