krickert commented on PR #1003: URL: https://github.com/apache/opennlp/pull/1003#issuecomment-4177590879
@rzo1 thanks for the quick feedback - I'll address all of these now. I found more areas that aren't thread safe - fixing now. I think this last push will cover all of them. As far as the deleted caches go, the tests showed no improvement was gained from them but also plan to discuss that further. I have no issue restoring them but if it's ok w/ya - I'll first make another set of changes and I'll give you a deeper reasoning re: cache removal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
