rzo1 commented on PR #1003: URL: https://github.com/apache/opennlp/pull/1003#issuecomment-4190928670
> > The eval build is fine: https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/44/ > > Thanks! What's the next step in the PR? It's my first contribution to open nlp. If you have any other concerns let me know. > > I saw it was turned to draft. Is it closer to getting out of draft mode? Thanks again for the contribution. Really appreciated, especially for a first PR! With the Easter holidays, reviews might be a bit slower than usual. Just as a heads-up: this is a volunteer-driven project, so reviews happen alongside people’s day jobs. Things will move forward, but it can take a bit of time to line everything up. At first glance, the changes look reasonable, but we’ll need a more thorough review before it can be merged in, i.e. try this out in some real-world scenarios/applications to see if there are any unexpected side effects or performance implications beyond the benchmarks (or run the benchmarks with larger datasets). We’ll follow up with more detailed feedback once we’ve had a chance to dig deeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
