rzo1 commented on code in PR #1003:
URL: https://github.com/apache/opennlp/pull/1003#discussion_r3055890617
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/featuregen/CachedFeatureGenerator.java:
##########
@@ -91,24 +119,21 @@ public void clearAdaptiveData() {
}
/**
- * @return Retrieves the number of times a cache hit occurred.
+ * @return Retrieves the number of cache hits for the current thread.
+ * @deprecated Cache statistics are no longer tracked.
*/
+ @Deprecated(since = "3.0.0")
public long getNumberOfCacheHits() {
- return numberOfCacheHits;
+ return 0;
}
/**
- * @return Retrieves the number of times a cache miss occurred.
+ * @return Retrieves the number of cache misses for the current thread.
+ * @deprecated Cache statistics are no longer tracked.
*/
+ @Deprecated(since = "3.0.0")
public long getNumberOfCacheMisses() {
- return numberOfCacheMisses;
Review Comment:
Do we need this generator if it doesn't have a cache anymore **or** should
it be renamed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
