krickert commented on code in PR #1003:
URL: https://github.com/apache/opennlp/pull/1003#discussion_r3059052065
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/featuregen/DocumentBeginFeatureGenerator.java:
##########
@@ -26,14 +26,16 @@
*/
public class DocumentBeginFeatureGenerator implements AdaptiveFeatureGenerator
{
Review Comment:
(a) Class is annotated `@ThreadSafe` now in 4334043.
(b) I did not add `AutoCloseable` on this one for the same reason as
`CachedFeatureGenerator`: lifecycle cleanup is the `ThreadLocal` story, and
`clearAdaptiveData()` already calls `remove()` where needed.
Also added a short field comment for the first-sentence tokens (see your
other note on this file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
