krickert commented on code in PR #1003:
URL: https://github.com/apache/opennlp/pull/1003#discussion_r3059073261
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/featuregen/PreviousMapFeatureGenerator.java:
##########
@@ -27,11 +27,11 @@
*/
public class PreviousMapFeatureGenerator implements AdaptiveFeatureGenerator {
Review Comment:
Done in https://github.com/ai-pipestream/opennlp/commit/4334043 — added
`@ThreadSafe` and a short note above `prevMap` so it’s obvious what the
ThreadLocal is holding.
On `AutoCloseable`: same take as `InSpanGenerator` for this PR; happy to
revisit if we want `close()` wired through everywhere consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
