krickert commented on code in PR #1003:
URL: https://github.com/apache/opennlp/pull/1003#discussion_r3059078221
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/featuregen/PreviousTwoMapFeatureGenerator.java:
##########
@@ -29,13 +29,14 @@
*/
public class PreviousTwoMapFeatureGenerator implements
AdaptiveFeatureGenerator {
Review Comment:
4334043 covers this one too: `@ThreadSafe` on the class plus a brief comment
on the `prevMaps` ThreadLocal (two-slot previous map).
Re `AutoCloseable`: aligned with the other feature generators — no `close()`
in this change set; shout if you want that pattern applied uniformly across the
board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
