krickert commented on code in PR #1003:
URL: https://github.com/apache/opennlp/pull/1003#discussion_r3059081290
##########
opennlp-core/opennlp-ml/opennlp-ml-commons/src/main/java/opennlp/tools/ml/BeamSearch.java:
##########
@@ -63,92 +84,82 @@ public BeamSearch(int size, MaxentModel model) {
}
/**
- * Initializes a {@link BeamSearch} instance.
+ * Initializes a {@link BeamSearch} instance with an optional per-thread
contexts cache.
*
* @param size The size of the beam (k).
* @param model The {@link MaxentModel} for assigning probabilities to the
sequence outcomes.
- * @param cacheSize The capacity of the {@link Cache} to use.
+ * @param cacheSize The capacity of the per-thread contexts cache. Use
{@code 0} to disable caching.
*/
public BeamSearch(int size, MaxentModel model, int cacheSize) {
this.size = size;
this.model = model;
-
- if (cacheSize > 0) {
- contextsCache = new Cache<>(cacheSize);
- }
-
- this.probs = new double[model.getNumOutcomes()];
+ this.cacheSize = cacheSize;
+ this.threadState = ThreadLocal.withInitial(
Review Comment:
I considered that shape, but left `threadState` as a `ThreadLocal` even when
`cacheSize == 0` on purpose: turning off the optional *contexts* cache is not
the same as having no per-thread state — `BeamSearch` still needs isolated
buffers for `eval` / beam work when multiple threads hit the same instance.
Dropping to `null` would just force a different place to stash that state
(or reintroduce races). Happy to add a one-line comment next to the field if
that helps future readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
