On 06/24/10 12:42, Niklas Nebel wrote:
On 06/24/10 12:29, Mathias Bauer wrote:
The idea is so good that someone is already working on it. :-)
There is ongoing work to replace a lot of ancient types like BOOL, USHORT etc. by sal_... types, with the exception that BOOL/FASTBOOl will be replaced by bool.

"BOOL -> bool" will cause problems. Memory usage for "new BOOL[n]", mixed use with sal_Bool (pointers, references), the occasional "special" value (SfxChildWinInfo::bVisible). Shouldn't we go the safe way and change BOOL to sal_Bool instead?

Re memory usage: BOOL[n] and bool[n] would each be n bytes in size, or what am I missing?

Re mixed use with sal_Bool: haven't encountered this problem often over the last years (and I liberally use bool instead of sal_Bool/BOOL since ages) -- also, it might be better to try to adapt the mismatching uses of sal_Bool to bool, too, leaving usage of sal_Bool to the only place it belongs, C++ UNO.

Re the occasional "special" value: I guess one day we should bite the bullet and clean those up for good.

-Stephan

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to