Hi, On Thursday, 2010-06-24 14:44:35 +0200, Mathias Bauer wrote:
> In result I expect that most "BOOL" can be replaced by "bool", while > some of them will become "sal_Bool". The misused "BOOLS" that in fact > are 8 Bit integer variables(*) IMHO should become a sal_uInt8/16 just to > show that they are *not* boolean. > > Anyway the change from BOOL to whatever is nothing that can be done just > with a script. That's different for e.g. USHORT. Just a quick idea: define BOOL (or FASTBOOL) as some class that has private ctors, conversion, assignment, bit and comparison operators for all integer types, but allow conversion to integers, define private SvStream operators, and public operators for comparison/conversion/assignment/construction with/to/from bool. Then compile the entire office ignoring return codes, i.e. let dmake not break, and wade through thousands of error messages.. A decent editor capable to digest compiler errors and position on the error is most helpful. I did similar back when we replaced (Byte)String with UniString, and when I changed Calc row variables from 16bit to 32bit, and it worked well. With a global BOOL replacement it would be quite some effort though. I think I still have that class layout and definitions for general use somewhere, so if anyone is interested and feels an itch.. ;-) Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [email protected] account, which I use for mailing lists only and don't read from outside Sun. Use [email protected] Thanks.
pgpe7B4o0sZ3T.pgp
Description: PGP signature
