rmannibucau commented on code in PR #126:
URL: https://github.com/apache/openwebbeans/pull/126#discussion_r1937512367
##########
webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java:
##########
@@ -1756,6 +1759,34 @@ protected void deployFromXML(ScannerService scanner)
}
logger.fine("Deploying configurations from XML has ended
successfully.");
+
+ try
Review Comment:
hmm not sure I got it right but my point is that this code shouldn't be
since the url should be injected in the scanner in SE mode so in owb-impl the
url should already be seen (thanks addDeploymentUrl call)
what we likely do not want is impl to depend on se (like in this pr)
hope it makes more sense phrased this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
