rmannibucau commented on code in PR #126:
URL: https://github.com/apache/openwebbeans/pull/126#discussion_r1965387032
##########
webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java:
##########
@@ -1756,6 +1759,34 @@ protected void deployFromXML(ScannerService scanner)
}
logger.fine("Deploying configurations from XML has ended
successfully.");
+
+ try
Review Comment:
guess it will need to call doAddWebBeansXmlLocation but looks like the
additional call to do
that said doing it in addDeploymentUrl will change the lifecycle for the
nominal case so i'd just align on the nominal case so adjust
CDISeScannerService (a bit like web scanner has web-inb url handling
specifically)
hope it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
