rmannibucau commented on code in PR #126:
URL: https://github.com/apache/openwebbeans/pull/126#discussion_r1937650817
##########
webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java:
##########
@@ -1756,6 +1759,34 @@ protected void deployFromXML(ScannerService scanner)
}
logger.fine("Deploying configurations from XML has ended
successfully.");
+
+ try
Review Comment:
Think we all agree the API should be respected and the regression be fixed
if any (maybe java related, didnt check if latest jre changed url handling),
but think we should stick to the original design of se on top of impl and not a
cycle dep and url 100% taken from the scanner, even virtual ones which were
just a hack to make it work without a new spi. This part can change if it help
- but think we can make it work, there should be something fishy making the
fake url dropped somewhere in the process.
can try to help to debug next week if there is no new finding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
