jgallimore commented on code in PR #126:
URL: https://github.com/apache/openwebbeans/pull/126#discussion_r1965260296
##########
webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java:
##########
@@ -1756,6 +1759,34 @@ protected void deployFromXML(ScannerService scanner)
}
logger.fine("Deploying configurations from XML has ended
successfully.");
+
+ try
Review Comment:
`addDeploymentUrl` is called from
`org.apache.openwebbeans.se.CDISeScannerService#addClassesDeploymentUrl` with
the embedded URL (great), however, the `scanner.getBeanXmls()` call from
`org.apache.webbeans.config.BeansDeployer#deployFromXML` does not return that
URL, as `addClassesDeploymentUrl` adds the URL to
`org.apache.webbeans.corespi.scanner.AbstractMetaDataDiscovery#beanDeploymentUrls`
and `scanner.getBeanXmls()` gets the URLs from
`org.apache.webbeans.corespi.scanner.AbstractMetaDataDiscovery#beanArchiveLocations`.
Could we just include the embedded URL in
`org.apache.webbeans.corespi.scanner.AbstractMetaDataDiscovery#beanArchiveLocations`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
