wgtmac commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727185159
##########
File path: c++/src/Reader.cc
##########
@@ -243,6 +249,18 @@ namespace orc {
footer->rowindexstride(),
getWriterVersionImpl(_contents.get())));
}
+
+ // Check if the file has inconsistent bloom filters.
+ hasBadBloomFilters = false;
+ if (footer->writer() == ORC_CPP_WRITER) {
+ const std::string &fullVersion = footer->softwareversion();
Review comment:
The softwareversion field was added recently. If the field is unset
here, it is probably created by C++ writer on an old version. We should also
set hasBadBloomFilters in this case.
##########
File path: c++/src/Reader.cc
##########
@@ -363,7 +381,7 @@ namespace orc {
throw ParseError("Failed to parse the row index");
}
rowIndexes[colId] = rowIndex;
- } else { // Stream_Kind_BLOOM_FILTER_UTF8
+ } else if (!hasBadBloomFilters) { // Stream_Kind_BLOOM_FILTER_UTF8
Review comment:
Should java reader do same thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
