[GitHub] [orc] stiga-huang commented on a change in pull request #934: ORC-1024: [C++] Fix inconsistent bloom filter hashing for numeric values

[GitBox]

stiga-huang commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727665977



##########
File path: c++/src/Reader.cc
##########
@@ -363,7 +381,7 @@ namespace orc {
             throw ParseError("Failed to parse the row index");
           }
           rowIndexes[colId] = rowIndex;
-        } else { // Stream_Kind_BLOOM_FILTER_UTF8
+        } else if (!hasBadBloomFilters) { // Stream_Kind_BLOOM_FILTER_UTF8

Review comment:
       Good point! Added checks and tests in Java codes as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org