stiga-huang commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727665795
##########
File path: c++/src/Reader.cc
##########
@@ -243,6 +249,18 @@ namespace orc {
footer->rowindexstride(),
getWriterVersionImpl(_contents.get())));
}
+
+ // Check if the file has inconsistent bloom filters.
+ hasBadBloomFilters = false;
+ if (footer->writer() == ORC_CPP_WRITER) {
+ const std::string &fullVersion = footer->softwareversion();
Review comment:
Nice catch! Added the checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
