[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360028#comment-14360028
]
Tilman Hausherr edited comment on PDFBOX-2576 at 3/13/15 10:52 AM:
-------------------------------------------------------------------
I applied your patch with two exceptions: 1. didn't suppress warnings because I
don't get any, and I'm not sure if we should suppress them at all; 2. this:
{code}
- else if( base instanceof COSObjectable && !(base instanceof COSBase)
)
+ else if( base instanceof COSBase)
{code}
this turns stuff into the opposite. (The good thing is that it results in a
test failure too, thus proving my fears). I always run the tests, including the
optional Bavaria tests, even if they take very long. Sometimes after
committing, but I run them.
was (Author: tilman):
I applied your patch with two exceptions: 1. didn't suppress warnings because I
don't get any, and I'm not sure if we should suppress them at all; 2. this:
{code}
- else if( base instanceof COSObjectable && !(base instanceof COSBase)
)
+ else if( base instanceof COSBase)
{code}
this turns stuff into the opposite. (The good thing is that it results in a
test failure too, thus proving my fears). I always run the tests, even if they
take very long (which is mostly "my fault", heh heh). Sometimes after
committing, but I run them.
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: pdfbox-override-patch.txt, pdfbox-raw-type-patch.txt,
> pdfcloneutility-patch.txt, pdftextstripperbyarea-patch.txt,
> ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
