[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378705#comment-14378705
]
John Hewson edited comment on PDFBOX-2576 at 3/24/15 9:47 PM:
--------------------------------------------------------------
Yes, it does, but those multiple places are on the same line. It's obvious that
there are no bugs in this code, nor is there any risk of bug being introduced
into this code. The downsides of the substantial code bloat and cognitive
burden of having to constantly look at the top of the file to see what the
constants are defined as isn't worth the supposed benefit, especially the as
benefit here is approximating zero.
One of the big problems I had with with some of the earlier code in PDFBox is
that there would often be constants such as TWO = "1" which made bugs damn near
impossible to find.
was (Author: jahewson):
Yes, it does, but those multiple places are on the same line. It's obvious that
there are no bugs in this code, nor is there any risk of bug being introduced
into this code. The downsides of the substantial code bloat and cognitive
burden of having to constantly look at the top of the file to see what the
constants are defined as isn't worth the supposed benefit, especially the
benefit here is approximating zero.
One of the big problems I had with with some of the earlier code in PDFBox is
that there would often be constants such as TWO = "1" which made bugs damn near
impossible to find.
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: GraphicsOperatorProcessor.patch,
> SecuryHandlerFactory.patch, org.apache.fontbox.afm.patch,
> org.apache.fontbox.cff.cffparser.patch, org.apache.fontbox.cff.patch,
> org.apache.fontbox.cmap.patch,
> org.apache.pdfbox.contentstream.operator.state.patch,
> org.apache.pdfbox.cos.patch, org.apache.pdfbox.filter-2.patch,
> org.apache.pdfbox.filter.patch, org.apache.pdfbox.pdfwriter.COSWriter.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.logicalstructure.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.patch,
> org.apache.pdfbox.preflight.graphic.patch, pdfbox-override-patch.txt,
> pdfbox-raw-type-patch.txt, pdfcloneutility-patch.txt,
> pdftextstripperbyarea-patch.txt, ttfsubsetter-2.patch, ttfsubsetter-3.patch,
> ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
