[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378745#comment-14378745
]
John Hewson edited comment on PDFBOX-2576 at 3/24/15 10:07 PM:
---------------------------------------------------------------
Not necessarily, we have separate modules which don't share dependencies which
both need to use the ".notdef" name, so there can never be one single
definition in PDFBox. There's no value in replacing ".notdef" with a constant,
because ".notdef" is already correct and typo-free. Now, if you find ".notdeF"
somewhere in our codebase, then that's a different matter, but as it stands
"avoiding typos" in code which is already typo-free isn't of any benefit.
If it's not broken, it doesn't need fixing. For example, doing a
find-and-replace on ".notdef" would only replace known-good code, and hence not
provide any benefit. It's "/nitdef", "nodef", ".motdef", etc. which actually
need replacing!
was (Author: jahewson):
Not necessarily, we have separate modules which don't share dependencies which
both need to use the ".notdef" name, so there can never be one single
definition in PDFBox. There's no value in replacing ".notdef" with a constant,
because ".notdef" is already correct and typo-free. Now, if you find ".notdeF"
somewhere in our codebase, then that's a different matter, but as it stands
"avoiding typos" in code which is already typo-free isn't of any benefit.
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: GraphicsOperatorProcessor.patch,
> SecuryHandlerFactory.patch, org.apache.fontbox.afm.patch,
> org.apache.fontbox.cff.cffparser.patch, org.apache.fontbox.cff.patch,
> org.apache.fontbox.cmap.patch,
> org.apache.pdfbox.contentstream.operator.state.patch,
> org.apache.pdfbox.cos.patch, org.apache.pdfbox.filter-2.patch,
> org.apache.pdfbox.filter.patch, org.apache.pdfbox.pdfwriter.COSWriter.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.logicalstructure.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.patch,
> org.apache.pdfbox.preflight.graphic.patch, pdfbox-override-patch.txt,
> pdfbox-raw-type-patch.txt, pdfcloneutility-patch.txt,
> pdftextstripperbyarea-patch.txt, ttfsubsetter-2.patch, ttfsubsetter-3.patch,
> ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
