[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362871#comment-14362871
 ] 

Tilman Hausherr edited comment on PDFBOX-2576 at 3/16/15 7:43 AM:
------------------------------------------------------------------

Partly done:
- kept the unused method
- didn't add those "syntehtic" annotations - what is the warning you get?

Re: "make constant strings reals constants" - not really needed, please make 
such changes only if there are other things, e.g. "make methods static" or 
"uneeded else clauses".


was (Author: tilman):
Partly done:
- kept the unused method
- didn't add those "syntehtic" annotations - what is the warning you get?
Re: "make constant strings reals constants" - not really needed, please make 
such changes only if there are other things, e.g. "make methods static" or 
"uneeded else clauses".

> Improve code quality
> --------------------
>
>                 Key: PDFBOX-2576
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2576
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>         Attachments: GraphicsOperatorProcessor.patch, 
> SecuryHandlerFactory.patch, org.apache.fontbox.afm.patch, 
> org.apache.fontbox.cff.cffparser.patch, 
> org.apache.pdfbox.contentstream.operator.state.patch, 
> org.apache.pdfbox.cos.patch, org.apache.pdfbox.filter-2.patch, 
> org.apache.pdfbox.filter.patch, 
> org.apache.pdfbox.pdmodel.documentinterchange.logicalstructure.patch, 
> org.apache.pdfbox.pdmodel.documentinterchange.patch, 
> org.apache.pdfbox.preflight.graphic.patch, pdfbox-override-patch.txt, 
> pdfbox-raw-type-patch.txt, pdfcloneutility-patch.txt, 
> pdftextstripperbyarea-patch.txt, ttfsubsetter-2.patch, ttfsubsetter-3.patch, 
> ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to