[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518844#comment-14518844
]
John Hewson edited comment on PDFBOX-2576 at 4/29/15 6:49 AM:
--------------------------------------------------------------
As I said on the mailing list, it makes more sense to remove getCOSDictionary()
because it is redundant. Simply change:
{code}
public COSBase getCOSObject() {
return this.dictionary;
}
{code}
to:
{code}
public COSDictionary getCOSObject() {
return this.dictionary;
}
{code}
The same is true of all getCOSXXXX() methods. because they're all just
subclasses of COSBase.
was (Author: jahewson):
As I said on the mailing list, it makes more sense to remove getCOSDictionary()
because it is redundant. Simply change:
{code}
public COSBase getCOSObject() {
...
}
{code}
to:
{code}
public COSDictionary getCOSObject() {
...
}
{code}
The same is true of all getCOSXXXX() methods. because they're all just
subclasses of COSBase.
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: ExtractText.2.patch, ExtractText.patch,
> GraphicsOperatorProcessor.patch, SecuryHandlerFactory.patch,
> Type5ShadingContext.patch, examples.arrayclone.patch,
> fontbox.arrayclone.patch, org.apache.fontbox.afm.patch,
> org.apache.fontbox.cff.cffparser.patch, org.apache.fontbox.cff.patch,
> org.apache.fontbox.cmap.patch,
> org.apache.pdfbox.contentstream.operator.state.patch,
> org.apache.pdfbox.cos.patch, org.apache.pdfbox.filter-2.patch,
> org.apache.pdfbox.filter.patch, org.apache.pdfbox.pdfwriter.COSWriter.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.logicalstructure.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.patch,
> org.apache.pdfbox.preflight.graphic.patch, org.apache.pdfbox.resource.patch,
> org.apache.pdfbox.text.testtextstripper.patch, pdfbox-override-patch.txt,
> pdfbox-raw-type-patch.txt, pdfbox.arrayclone.patch,
> pdfcloneutility-patch.txt, pdftextstripperbyarea-patch.txt,
> ttfsubsetter-2.patch, ttfsubsetter-3.patch, ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
