[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518815#comment-14518815
]
John Hewson edited comment on PDFBOX-2576 at 4/29/15 6:37 AM:
--------------------------------------------------------------
Sorry but this change a) breaks my patches and b) makes the code harder to
read... it previously fit on my screen, now it doesn't. Assigning all encoding
state in one longer linear method is far cleaner than fanning it out to various
other non-linear state-mutating methods. Sonar just doesn't _understand_ what's
going on here.
Breaking up long methods is highly subjective. We need to discuss these kinds
of things first, because it's making the SVN log messy...
was (Author: jahewson):
Sorry but this change a) breaks my patches and b) makes the code harder to
read... it previously fit on my screen, now it doesn't. Assigning all encoding
state in one longer method is far cleaner than fanning it out to various other
state-mutating methods. Sonar just doesn't _understand_ what's going on here.
Breaking up long methods is highly subjective. We need to discuss these kinds
of things first, because it's making the SVN log messy...
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: ExtractText.2.patch, ExtractText.patch,
> GraphicsOperatorProcessor.patch, SecuryHandlerFactory.patch,
> Type5ShadingContext.patch, examples.arrayclone.patch,
> fontbox.arrayclone.patch, org.apache.fontbox.afm.patch,
> org.apache.fontbox.cff.cffparser.patch, org.apache.fontbox.cff.patch,
> org.apache.fontbox.cmap.patch,
> org.apache.pdfbox.contentstream.operator.state.patch,
> org.apache.pdfbox.cos.patch, org.apache.pdfbox.filter-2.patch,
> org.apache.pdfbox.filter.patch, org.apache.pdfbox.pdfwriter.COSWriter.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.logicalstructure.patch,
> org.apache.pdfbox.pdmodel.documentinterchange.patch,
> org.apache.pdfbox.preflight.graphic.patch, org.apache.pdfbox.resource.patch,
> org.apache.pdfbox.text.testtextstripper.patch, pdfbox-override-patch.txt,
> pdfbox-raw-type-patch.txt, pdfbox.arrayclone.patch,
> pdfcloneutility-patch.txt, pdftextstripperbyarea-patch.txt,
> ttfsubsetter-2.patch, ttfsubsetter-3.patch, ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
