[ https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900506#comment-14900506 ]
Maruan Sahyoun commented on PDFBOX-2852: ---------------------------------------- [~tilman] that's already a very good achievement looking at where we came from. There are some more substantial issues we could look at and resolve such as the package cycles e.g. in org/apache/pdfbox/contentstream. There would also be the option to look at the org/apache/pdfbox/pdmodel/font/encoding package and resolve the Magic Number issues for a quick win although we could argue if that is beneficial from a code quality perspective (I'm in favor of doing it). Resolving the package cycle issue in org/apache/pdfbox/contentstream should be possible (e.g. by using a visitor pattern approach) but obviously that's an API breaking change with a high potential for regressions which I won't see us doing for 2.0.0. > Improve code quality (2) > ------------------------ > > Key: PDFBOX-2852 > URL: https://issues.apache.org/jira/browse/PDFBOX-2852 > Project: PDFBox > Issue Type: Task > Affects Versions: 2.0.0 > Reporter: Tilman Hausherr > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2576, which was getting too long. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org