[
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900944#comment-14900944
]
Maruan Sahyoun commented on PDFBOX-2852:
----------------------------------------
That's of course doable.
- the comment could either be handled as a code comment or explicitly by having
an 'extras' array
- the bullet logic can be added easily the same way as it was before (now the
bullets are already part of the array)
for the numbers - do you prefer the octals?
Shall I come up with another patch for it as initially I made the patch for
discussion purposes only (and verified with my local SonarQube instance that
the Magic Number warning goes away, as there are others as I'm using a newer
release)
> Improve code quality (2)
> ------------------------
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: winansiencoding.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
