[
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900939#comment-14900939
]
Tilman Hausherr commented on PDFBOX-2852:
-----------------------------------------
I don't like the visitor pattern. Double dispatch adds an extra level of
bureaucracy, and gives a feeling of "finding permit A38". It cost me extra time
to find the error in PDFBOX-2977.
I didn't work on most of the magic numbers, because I disagree with many of
these Sonar pet peeves. I.e. an "8" (for 8 bits) should be "8" and not
BITS_PER_BYTE or whatever.
> Improve code quality (2)
> ------------------------
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: winansiencoding.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
