[
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900962#comment-14900962
]
Maruan Sahyoun commented on PDFBOX-2852:
----------------------------------------
{quote}
I don't like the visitor pattern.
{quote}
It has pros and cons of course and was only mentioned as one possibility.
However we solve it I think we should look at handling that as I think that
these cycles should be avoided if there is not too much effort involved.
{quote}
because I disagree with many of these Sonar pet peeves
{quote}
I also wouldn't look at removing all of them just to please Sonar. At the end
it's our decision of how we handle the suggestions being made. For the ones
related to encoding I think the code is still clear after the changes. We
could disable the warnings but I prefer keeping them as it forces us to think
about them. E.g. if we have some code like
{code}
foo = bar[0]
{code}
it might enhance the code to give the index a name (although it's much quicker
to not do it).
> Improve code quality (2)
> ------------------------
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: winansiencoding.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
