[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005099#comment-15005099
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44853408
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/tx/TxPointInTimeQueryIT.java ---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.tx;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.fail;
    +
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.SQLException;
    +import java.util.Properties;
    +
    +import org.apache.phoenix.end2end.BaseClientManagedTimeIT;
    +import org.apache.phoenix.exception.SQLExceptionCode;
    +import org.apache.phoenix.util.PhoenixRuntime;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class TxPointInTimeQueryIT extends BaseClientManagedTimeIT {
    +
    +   protected long ts;
    +
    +   @Before
    +   public void initTable() throws Exception {
    +           ts = nextTimestamp();
    +   }
    +
    +   @Test
    +   public void testQueryWithSCN() throws Exception {
    +           Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
    +           props.put(PhoenixRuntime.CURRENT_SCN_ATTRIB, Long.toString(ts));
    +           try (Connection conn = DriverManager.getConnection(getUrl(), 
props);) {
    +                   try {
    +                           conn.createStatement()
    --- End diff --
    
    Minor nit: formatting looks off.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to