[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005080#comment-15005080
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853079
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java ---
@@ -313,7 +313,7 @@ public static int executeStatements(Connection conn,
Reader reader, List<Object>
*/
public static Iterator<Pair<byte[],List<KeyValue>>>
getUncommittedDataIterator(Connection conn, boolean includeMutableIndexes)
throws SQLException {
final PhoenixConnection pconn =
conn.unwrap(PhoenixConnection.class);
- final Iterator<Pair<byte[],List<Mutation>>> iterator =
pconn.getMutationState().toMutations(includeMutableIndexes);
+ final Iterator<Pair<byte[],List<Mutation>>> iterator =
pconn.getMutationState().toMutations(includeMutableIndexes, null);
--- End diff --
Overload toMutations if possible so null isn't required here.
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
