[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005091#comment-15005091
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44853223
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorWithSplitsAndMultiCFIT.java
 ---
    @@ -176,7 +176,7 @@ public void testSplitUpdatesStats() throws Exception {
             Collection<GuidePostsInfo> infos = 
TestUtil.getGuidePostsList(conn, STATS_TEST_TABLE_NAME);
             for (GuidePostsInfo info : infos) {
                 assertEquals(20, info.getRowCount());
    -            assertEquals(11020, info.getByteCount());
    +            assertEquals(11040, info.getByteCount());
    --- End diff --
    
    I believe it's because our empty column value isn't empty any longer. We 
need it to have a value so that Tephra doesn't treat it as a delete marker. We 
could conditionally use an empty value if the table is non transactional, but 
meh.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to