[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005073#comment-15005073
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44852894
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2578,17 +2745,18 @@ public MutationState addColumn(AddColumnStatement
statement) throws SQLException
}
}
- if (numPkColumnsAdded>0 && !table.getIndexes().isEmpty()) {
+ if (!table.getIndexes().isEmpty() && (numPkColumnsAdded>0
|| nonTxToTx)) {
for (PTable index : table.getIndexes()) {
- incrementTableSeqNum(index, index.getType(),
numPkColumnsAdded);
+ incrementTableSeqNum(index, index.getType(),
numPkColumnsAdded, nonTxToTx ? Boolean.TRUE : null);
}
-
tableMetaData.addAll(connection.getMutationState().toMutations().next().getSecond());
+
tableMetaData.addAll(connection.getMutationState().toMutations(timeStamp).next().getSecond());
connection.rollback();
}
long seqNum = table.getSequenceNumber();
if (changingPhoenixTableProperty || columnDefs.size() > 0)
{
- seqNum = incrementTableSeqNum(table,
statement.getTableType(), columnDefs.size(), isImmutableRows, disableWAL,
multiTenant, storeNulls);
-
tableMetaData.addAll(connection.getMutationState().toMutations().next().getSecond());
+ // TODO: verify master has fix for multiple data
columns added and unit test
--- End diff --
Remove TODO please.
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
