Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/261#discussion_r123725378
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -196,7 +196,8 @@ public static ColumnResolver 
getResolverForCreation(final CreateTableStatement s
                         if (htable != null) Closeables.closeQuietly(htable);
                     }
                     tableNode = NamedTableNode.create(null, baseTable, 
statement.getColumnDefs());
    -                return new SingleTableColumnResolver(connection, 
tableNode, e.getTimeStamp(), new HashMap<String, UDFParseNode>(1), false);
    +                boolean isNamespaceMapped = 
SchemaUtil.isNamespaceMappingEnabled(statement.getTableType(), 
connection.getQueryServices().getProps());
    --- End diff --
    
    I think it is necessary. How about asserting in the test that tables are 
mapped properly. You can like this.
    
assert(QueryUtil.getExplainPlan(conn.createStatement().executeQuery("explain 
select * from \""+ ns + "." + table+"\"")).contains(ns+"."+table));


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to