Github user brfrn169 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/261#discussion_r123954850
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -983,14 +983,21 @@ public static boolean hasRowTimestampColumn(PTable
table) {
return SchemaUtil.getTableKey(null, schemaName,
MetaDataClient.EMPTY_TABLE);
}
- public static PName getPhysicalHBaseTableName(PName pName, boolean
isNamespaceMapped, PTableType type) {
- return getPhysicalHBaseTableName(pName.toString(),
isNamespaceMapped, type);
+ public static PName getPhysicalHBaseTableName(PName schemaName, PName
tableName, boolean isNamespaceMapped) {
--- End diff --
I added "schemaName" as an argument to this method.
I think we need both schemaName and tableName to handle a table like
"AAA.BBB" in default schema correctly, because if we have only the table name
"AAA.BBB", we can't distinguish between "AAA.BBB" in the default schema and
"BBB" in "AAA" schema.
Also we don't need the "type" argument, so I deleted it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
