Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/261#discussion_r123726523
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -1420,7 +1420,7 @@ public MetaDataMutationResult createTable(final 
List<Mutation> tableMetaData, fi
             byte[] tenantIdBytes = 
rowKeyMetadata[PhoenixDatabaseMetaData.TENANT_ID_INDEX];
             byte[] schemaBytes = 
rowKeyMetadata[PhoenixDatabaseMetaData.SCHEMA_NAME_INDEX];
             byte[] tableBytes = 
rowKeyMetadata[PhoenixDatabaseMetaData.TABLE_NAME_INDEX];
    -        byte[] tableName = physicalTableName != null ? physicalTableName : 
SchemaUtil.getTableNameAsBytes(schemaBytes, tableBytes);
    +        byte[] tableName = SchemaUtil.getTableNameAsBytes(schemaBytes, 
tableBytes);
    --- End diff --
    
    Why we need this change? I think it should be physical table name, we need 
it to verify meta data when views created on phoenix table (create view v as 
select * from table) in ensureTableCreated(tableName, tableType, tableProps, 
families, splits, true, isNamespaceMapped);



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to