Github user brfrn169 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/261#discussion_r123960912
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -983,14 +983,21 @@ public static boolean hasRowTimestampColumn(PTable
table) {
return SchemaUtil.getTableKey(null, schemaName,
MetaDataClient.EMPTY_TABLE);
}
- public static PName getPhysicalHBaseTableName(PName pName, boolean
isNamespaceMapped, PTableType type) {
- return getPhysicalHBaseTableName(pName.toString(),
isNamespaceMapped, type);
+ public static PName getPhysicalHBaseTableName(PName schemaName, PName
tableName, boolean isNamespaceMapped) {
+ return getPhysicalHBaseTableName(
+ schemaName == null ? null : schemaName.toString(),
tableName.toString(), isNamespaceMapped);
}
- public static PName getPhysicalHBaseTableName(byte[] tableName,
boolean isNamespaceMapped, PTableType type) {
- return getPhysicalHBaseTableName(Bytes.toString(tableName),
isNamespaceMapped, type);
+ public static PName getPhysicalHBaseTableName(byte[] schemaName,
byte[] tableName, boolean isNamespaceMapped) {
+ return getPhysicalHBaseTableName(Bytes.toString(schemaName),
Bytes.toString(tableName), isNamespaceMapped);
}
+ /**
--- End diff --
As per this comment, the 4 methods (getPhysicalTableName, getPhysicalName)
can return an unexpected value.
I don't believe this situation has been seen in the wild as-of-yet, however
users should be aware of this behaviour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
