I agree. These are all major bugs and we should aim at solving them after checking that they are still issues. I am +1 on 5833 and I think 5484 would be a great addition to 4.16 as well. We should aim at resolving high priority bugs like this in every release.
Sometimes we let these bugs slip without a resolution before a release, citing that these are "known issues" or "not regressions from the last release". In some cases this may be fine since we want to keep releases light and frequent, but perhaps we can track such issues and aim at reducing the number of bugs by x% in each release? This will also keep old Jiras alive since we will potentially periodically review them. On Tue, Dec 1, 2020 at 4:01 PM Geoffrey Jacoby <gjac...@apache.org> wrote: > I've got PHOENIX-5435 in review right now, and would like to get it in 4.16 > / 5.1. > > It's allowing the annotation of Phoenix metadata into HBase WALs as a > pre-req for the Phoenix Change Detection Capture framework (PHOENIX-5442). > Since it has both client/server logic, and adds a field to System.Catalog, > it can't go in a patch release. > > Depending on timing, I'd _like_ to get PHOENIX-6227, which is the last part > of CDC that will go into core Phoenix, into 4.16, but since that _can_ go > in a patch release and I haven't started it yet, if the release gets cut > before it's ready, no big deal. (The rest of CDC will go into > phoenix-connectors for a future release of that project.) > > As for the correctness problems that Daniel points out, I think we should > fix the ones that were detected with a recent version (4.14 or 4.15?), and > test to see which of the older ones can still be reproduced. Once we know > which bugs are real and which are just historical, we can better judge > scope. And hopefully close a bunch of obsolete bugs. (Thanks, Daniel, for > collecting that list!) > > Geoffrey > > > > On Tue, Dec 1, 2020 at 1:33 PM Daniel Wong > <daniel.w...@salesforce.com.invalid> wrote: > > > Hi, I wanted to bring up wrong results in Phoenix and some JIRAs around > > them that I think we should fix as the wrong result lessens the end > user's > > trust in Phoenix. Releasing a new version without addressing these in a > > minor release hurts our visibility in that these critical issues are not > > addressed. > > > > Jira's that I'm involved with for example: I've already given a patch > > several months ago for 5833 and there is a chance it may fix 5484. > > https://issues.apache.org/jira/browse/PHOENIX-5833 > > https://issues.apache.org/jira/browse/PHOENIX-5484 > > > > In addition, inspecting apache JIRA i see several other wrong result > JIRAs > > from the community. Some of these certainly are probably old issues or > > incorrect understanding but some of these are opened by our own dev > > community and are likely real problems. > > https://issues.apache.org/jira/browse/PHOENIX-6217 > > https://issues.apache.org/jira/browse/PHOENIX-5571 > > https://issues.apache.org/jira/browse/PHOENIX-4642 > > https://issues.apache.org/jira/browse/PHOENIX-4540 > > https://issues.apache.org/jira/browse/PHOENIX-4504 > > https://issues.apache.org/jira/browse/PHOENIX-4419 > > https://issues.apache.org/jira/browse/PHOENIX-4116 > > > > What is our stance on this type of issue? Are we going to say these were > > issues prior to 4.15 and not address them? Should we have requirements > for > > our releases to fix wrong results? > > > > Daniel Wong > > > > On Mon, Nov 30, 2020 at 7:30 PM Xinyi Yan <yanxi...@apache.org> wrote: > > > > > Hi all, > > > > > > It's time to discuss the Phoenix 4.16 release. After many people's > > > contributions on the bug fixes, new features, and other works in the > past > > > few months, we are kind of close to the point to have a RC (still need > to > > > fix test flappers). Please let me know if you think any JIRA must be > part > > > of the Phoenix 4.16 release other than major blocker PHOENIX-5712. > > > > > > If no surprise comes up, I will not wait for any new major features and > > > focus on the RC as soon as possible. > > > > > > Sincerely, > > > Xinyi > > > > > > > > > -- > > Daniel Wong > > Salesforce > > Mobile: 628.217.1808 > > > -- Chinmay Kulkarni
