I wasted too much time yesterday realizing that TaskGroup &
TaskSequence don't use the java.util.concurrent.ExecutorService that
might be passed to their constructors.

http://pivot.apache.org/2.0/docs/api/org/apache/pivot/util/concurrent/TaskGroup.html#TaskGroup(java.util.concurrent.ExecutorService)
http://pivot.apache.org/2.0/docs/api/org/apache/pivot/util/concurrent/TaskSequence.html#TaskSequence(java.util.concurrent.ExecutorService)

This probably stems from https://issues.apache.org/jira/browse/PIVOT-35

I can't really work out the intent of the classes from the javadocs or
decide if they are still required (at least in their current forms).
Neither is used within Pivot itself.

Are they supposed to use a provided ExecutorService or is the
constructor just a copy & paste mistake?  i.e. Should the classes be
updated to actually use what is supplied to them, or should the
contructors be removed?

If the former, then it is probably worth adding a
setExecutorService(ExecutorService) method to
org.apache.pivot.util.concurrent.Task so that TaskGroup & TaskSequence
can control the ExecutorService to use when running the individual
tasks.

Chris

Reply via email to