[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584459#comment-16584459 ]
Roger Whitcomb commented on PIVOT-1032: --------------------------------------- Fixed the remaining LineLength errors, some AvoidNestedBlocks errors and many other (mostly non-final parameter errors) in these files: Sending charts/src/org/apache/pivot/charts/ChartView.java Sending core/src/org/apache/pivot/beans/BXMLSerializer.java Sending core/src/org/apache/pivot/collections/Sequence.java Sending core/src/org/apache/pivot/collections/adapter/ListAdapter.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableList.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableMap.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableSet.java Sending core/src/org/apache/pivot/text/AttributedStringCharacterIterator.java Sending core/src/org/apache/pivot/util/CharUtils.java Sending core/src/org/apache/pivot/util/ImageUtils.java Sending core/src/org/apache/pivot/util/ImmutableIterator.java Sending core/src/org/apache/pivot/util/Utils.java Sending core/test/org/apache/pivot/util/test/CharUtilsTest.java Sending demos/src/org/apache/pivot/demos/roweditor/CurrencyValidator.java Sending demos/src/org/apache/pivot/demos/styles/ColorSchemeBuilderWindow.java Sending eclipse/src/org/apache/pivot/eclipse/PivotApplicationLaunchShortcut.java Sending eclipse/src/org/apache/pivot/eclipse/PivotScriptApplicationLaunchShortcut.java Sending tests/src/org/apache/pivot/tests/ApplicationWithPropertiesTest.java Sending tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java Sending tests/src/org/apache/pivot/tests/FileBrowserWithCharsetTest.java Sending tests/src/org/apache/pivot/tests/LabelAntialiasTest.java Sending tests/src/org/apache/pivot/tests/SheetTest.java Sending tests/src/org/apache/pivot/tests/TextAreaConsoleTest.java Sending tests/src/org/apache/pivot/tests/issues/Pivot765.java Sending tests/src/org/apache/pivot/tests/issues/Pivot862.java Sending tutorials/src/org/apache/pivot/tutorials/KitchenSink.java Sending tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspector.java Sending tutorials/src/org/apache/pivot/tutorials/webqueries/Expenses.java Sending wtk/src/org/apache/pivot/wtk/Accordion.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/CalendarButton.java Sending wtk/src/org/apache/pivot/wtk/ColorChooser.java Sending wtk/src/org/apache/pivot/wtk/ColorChooserButton.java Sending wtk/src/org/apache/pivot/wtk/ListButton.java Sending wtk/src/org/apache/pivot/wtk/SuggestionPopup.java Sending wtk/src/org/apache/pivot/wtk/TablePane.java Sending wtk/src/org/apache/pivot/wtk/TablePaneAttributeListener.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/TableViewHeader.java Sending wtk/src/org/apache/pivot/wtk/TextInputMethodListener.java Sending wtk/src/org/apache/pivot/wtk/Window.java Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CardPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ColorChooserButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/LabelSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/NumberRulerSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ScrollPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollBarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSplitPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSheetSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data ............................................................done Committing transaction... Committed revision 1838293. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)