[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590444#comment-16590444 ]
Roger Whitcomb commented on PIVOT-1032: --------------------------------------- Fix the rest of AvoidNestedBlocks errors (except for two, which were hard to get right without the nested blocks), as well as other errors in the affected files: Sending core/src/org/apache/pivot/xml/XMLSerializer.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/GraphicsUtilities.java Sending wtk/src/org/apache/pivot/wtk/ImageView.java Sending wtk/src/org/apache/pivot/wtk/ListView.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/effects/TagDecorator.java Sending wtk/src/org/apache/pivot/wtk/media/Picture.java Sending wtk/src/org/apache/pivot/wtk/skin/BoxPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CardPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ContainerSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/FlowPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAccordionSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSheetSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSplitPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewHeaderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTextInputSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSheetSkin.java Transmitting file data .........................done Committing transaction... Committed revision 1838738. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)