[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101846#comment-17101846
]
Roger Lee Whitcomb commented on PIVOT-1032:
-------------------------------------------
Updates to the style summary report:
Sending build.xml
Transmitting file data .done
Committing transaction...
Committed revision 1877480.
Current results with these changes:
{code}check-style:
[cs:checkstyle] Running Checkstyle 8.8 on 937 files
[echo] Style Check Results
[echo] (full report in "style_errors.log", this summary also in
"style_summary.log")
[echo] # Category Count File(s)
[echo] --- ---------------------------- ----- ---------------
[echo] 1. [FinalClass] 1 (TerraTreeViewSkin.java)
[echo] 2. [FileLength] 3 (ApplicationContext.java,
Component.java, TerraTreeViewSkin.java)
[echo] 3. [MethodLength] 10 (9)
[echo] 4. [UnusedImports] 11 (7)
[echo] 5. [ParenPad] 33 (CSSColor.java)
[echo] 6. [InnerAssignment] 38 (19)
[echo] 7. [TodoComment] 71 (34)
[echo] 8. [JavadocPackage] 101 (100)
[echo] 9. [VisibilityModifier] 258 (83)
[echo] 10. [JavadocType] 483 (329)
[echo] 11. [AvoidInlineConditionals] 518 (187)
[echo] 12. [RedundantModifier] 678 (276)
[echo] 13. [MagicNumber] 1615 (222)
[echo] 14. [HiddenField] 2161 (283)
[echo] 15. [JavadocVariable] 3991 (540)
[echo] 16. [JavadocMethod] 4199 (593)
[echo] 17. [DesignForExtension] 4593 (637)
[echo] 18. [FinalParameters] 9676 (659)
[echo] --- ---------------------------- ----- ---------------
[echo] Totals 28440 (911)
{code}
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Lee Whitcomb
> Assignee: Roger Lee Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
